feat(DAPP-7450): add typescript build command to compile #38
Conversation
jeffrifwaldsmartcontract
commented
Sep 26, 2025
jeffrifwaldsmartcontract
commented
- Adds shared build command for deploy/simulate workflows.
jeffrifwaldsmartcontract
requested review from
shileiwill and
ernest-nowacki
jeffrifwaldsmartcontract
force-pushed
the
DAPP-7450-ts-deploy
branch
from
409c4dc to
8956203
Compare
|
|
||
| // Gets a build command for either Golang or Typescript based on the filename | ||
| func GetBuildCmd(inputFile string, outputFile string, rootFolder string) *exec.Cmd { | ||
| isTypescriptWorkflow := strings.HasSuffix(inputFile, ".ts") |
There was a problem hiding this comment.
this is not safe after this change: https://github.com/smartcontractkit/cre-cli/pull/36/files#r2382877260
cc @timothyF95 who is working on providing a path instead of the main.go.
There was a problem hiding this comment.
@jeffrifwaldsmartcontract for typescipt, do we have to specify the x.ts file or it is okay to just give the path of the workflow directory where the x.ts lives? Relevant ticket: https://smartcontract-it.atlassian.net/browse/DEVSVCS-2420
There was a problem hiding this comment.
We can adapt this to however Go wants to ultimately address figuring out what the input file is. Right now the inputFile is read from the command line, so examining that filename is the easiest.
Looking at the proposals, maybe we can instead just read the directory and see if main.go or main.ts exists in the folder.
There was a problem hiding this comment.
Let me know if you think this is OK for now or if we want to wait on this until those other tickets are resolved.
There was a problem hiding this comment.
if we go with the directory approach, what if there are multiple ts files in the directory? For go, it compiles and build the whole directory, so it doesnt matter. I am not sure about TS.
There was a problem hiding this comment.
I think I'll need to see how the Go compile command will ultimately be utilized. It is certainly possible to scan a directory tree for ts files, but is there something inherently special about the file name main.go or main.ts in those directories?
There was a problem hiding this comment.
Basically, how do we figure out the workflow entry point when dealing with a directory? I might have a bunch of scripts sitting around with .ts extensions that I don't want compiled.
There was a problem hiding this comment.
cc @silaslenihan @yashnevatia. for go, they build the whole directory. Ref: https://github.com/smartcontractkit/cre-cli/pull/36/files#r2388501556
There was a problem hiding this comment.
the way Go build is gonna be GOOS=wasip1 GOARCH=wasm go build -o w.wasm ./DirectoryOfWorkflowEntry.
I guess if TS has to specify the TS entry file, we can treat Go and TS differently in the setting, where Go is directory of workflow, while TS is the path to ts file (e.g. main.ts)
Thoughts @ejacquier @timothyF95
|
|
||
| // Gets a build command for either Golang or Typescript based on the filename | ||
| func GetBuildCmd(inputFile string, outputFile string, rootFolder string) *exec.Cmd { | ||
| isTypescriptWorkflow := strings.HasSuffix(inputFile, ".ts") |
There was a problem hiding this comment.
@jeffrifwaldsmartcontract for typescipt, do we have to specify the x.ts file or it is okay to just give the path of the workflow directory where the x.ts lives? Relevant ticket: https://smartcontract-it.atlassian.net/browse/DEVSVCS-2420
jeffrifwaldsmartcontract
force-pushed
the
DAPP-7450-ts-deploy
branch
from
788638c to
a66ba9c
Compare
